Fix getTopWindowUrl #2673
Merged
Fix getTopWindowUrl #2673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 4, 2018 16:44
getTopWindowUrl error, it should be exports.function not this.function
Fix to pass FB test
harpere
reviewed
Jun 5, 2018
|
As discussed I have edited to the correct behaviour and edit some change on Karma test for AudienceNetwork adapter. |
harpere
added
needs 2nd review
jaiminpanchal27
approved these changes
Jun 7, 2018
This was referenced Jun 7, 2018
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* Fix getTopWindowUrl getTopWindowUrl error, it should be exports.function not this.function * Update utils.js Fix to pass FB test * Update audienceNetworkBidAdapter_spec.js * Update utils.js * Update utils.js * Update utils.js
florevallatmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Sep 6, 2018
* Fix getTopWindowUrl getTopWindowUrl error, it should be exports.function not this.function * Update utils.js Fix to pass FB test * Update audienceNetworkBidAdapter_spec.js * Update utils.js * Update utils.js * Update utils.js
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
* Fix getTopWindowUrl getTopWindowUrl error, it should be exports.function not this.function * Update utils.js Fix to pass FB test * Update audienceNetworkBidAdapter_spec.js * Update utils.js * Update utils.js * Update utils.js
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* Fix getTopWindowUrl getTopWindowUrl error, it should be exports.function not this.function * Update utils.js Fix to pass FB test * Update audienceNetworkBidAdapter_spec.js * Update utils.js * Update utils.js * Update utils.js
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* Fix getTopWindowUrl getTopWindowUrl error, it should be exports.function not this.function * Update utils.js Fix to pass FB test * Update audienceNetworkBidAdapter_spec.js * Update utils.js * Update utils.js * Update utils.js
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* Fix getTopWindowUrl getTopWindowUrl error, it should be exports.function not this.function * Update utils.js Fix to pass FB test * Update audienceNetworkBidAdapter_spec.js * Update utils.js * Update utils.js * Update utils.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getTopWindowUrl error, it should be exports.function not this.function
FB adapter is relying on this for getting the top location and for Postbid in Safeframe the referer is not passed. exports.getTopWindowLocation() should be used if this.getTopWindowLocation is not defined.
The FB JS test is made so pagueUrl must be void instead of returning the page (localhost for) or url format. That is why I was forced to do if (href.search(‘localhost/?‘) > 0) { href = ‘’; }
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information